Skip to content

fix: unit tests for sync volume#3881

Merged
tenthirtyam merged 1 commit intovmware:mainfrom
nikhilbarge:topic/nb002579/fix_tests
Oct 6, 2025
Merged

fix: unit tests for sync volume#3881
tenthirtyam merged 1 commit intovmware:mainfrom
nikhilbarge:topic/nb002579/fix_tests

Conversation

@nikhilbarge
Copy link
Copy Markdown
Contributor

@nikhilbarge nikhilbarge commented Oct 6, 2025

Description

Fix unit tests for sync volume

Please include a summary of the change.
updated unit tests

Closes: #(issue-number)

How Has This Been Tested?

Unit tests
logs:
client_test.log

Please describe any manual tests done to verify your changes.

Guidelines

Please read and follow the CONTRIBUTION guidelines of this project.

@nikhilbarge nikhilbarge force-pushed the topic/nb002579/fix_tests branch from fa61844 to ed7ea33 Compare October 6, 2025 09:47
Copy link
Copy Markdown
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikhilbarge - could you sign-off using your @broadcom.com email instead of @vmware.com?

@tenthirtyam tenthirtyam changed the title Fix unit tests for sync volume [wip] fix: unit tests for sync volume Oct 6, 2025
@tenthirtyam tenthirtyam marked this pull request as draft October 6, 2025 13:44
@nikhilbarge nikhilbarge force-pushed the topic/nb002579/fix_tests branch 2 times, most recently from 3691ef9 to 1a9bcb2 Compare October 6, 2025 14:24
@nikhilbarge
Copy link
Copy Markdown
Contributor Author

@nikhilbarge - could you sign-off using your @broadcom.com email instead of @vmware.com?

done

@tenthirtyam tenthirtyam marked this pull request as ready for review October 6, 2025 14:48
Copilot AI review requested due to automatic review settings October 6, 2025 14:48
@tenthirtyam tenthirtyam changed the title [wip] fix: unit tests for sync volume fix: unit tests for sync volume Oct 6, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes unit tests for sync volume functionality by relocating the CnsSyncVolume API test to an earlier position in the test sequence and adding environment variable setup for test configuration.

  • Moved CnsSyncVolume API test from the end of TestClient to an earlier position after volume creation
  • Added environment variable setup for CNS configuration including datastore, datacenter, VC URL, and resource pool path

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@nikhilbarge nikhilbarge force-pushed the topic/nb002579/fix_tests branch from 1a9bcb2 to 12219dd Compare October 6, 2025 14:51
Signed-off-by: Nikhil Barge <nikhil.barge@broadcom.com>
@nikhilbarge nikhilbarge force-pushed the topic/nb002579/fix_tests branch from 12219dd to e00e51c Compare October 6, 2025 14:55
@tenthirtyam tenthirtyam requested a review from akutz October 6, 2025 15:54
@tenthirtyam
Copy link
Copy Markdown
Contributor

@nikhilbarge A couple tests are failing because you don't have SSH keys.

@nikhilbarge
Copy link
Copy Markdown
Contributor Author

@nikhilbarge A couple tests are failing because you don't have SSH keys.

thanks for pointing out, i have added ssh key. tests are passed

@tenthirtyam tenthirtyam merged commit 7b6d459 into vmware:main Oct 6, 2025
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants