fix: guard against nil role in permissions.ls#3840
Merged
tenthirtyam merged 1 commit intomainfrom Aug 20, 2025
Merged
Conversation
Adds a check to prevent panic when RoleId lookup returns nil in the permissions list output. Falls back to displaying the RoleId as a string if the role is not found. Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Safely handle cases where the role may not exist by defaulting to the role ID as a string, and only using the role name if it is present.
Updates the role name display in
func (l *List) Write(w io.Writer) errorincli/permissions/permissions.go, preventing potential nil pointer errors by falling back to the role ID when the role is not found.Closes #3833