Update generated types to vSphere 8.0 GA#3006
Merged
akutz merged 6 commits intovmware:masterfrom Dec 12, 2022
Merged
Conversation
dd2c301 to
9e7ab0c
Compare
ea7b1dc to
188ce3d
Compare
This patch updates the generated types to vSphere 8.0 GA.
This patch fixes a bug where "govc about.cert" was not respecting the -k flag (or env var) that disabled TLS verification.
This patch updates the cert/key pairs vC Sim uses for testing to be RSA 2048 in accordance with Apple's new requirements on macOS. https://developer.apple.com/documentation/security/preventing_insecure_network_connections
This patch updates the GoVmomi SOAP client to use DialTLSContext instead of DialTLS, as the latter has been deprecated for multiple, major Go versions. This patch also updates how the SOAP client handles TLS validation with respect to thumbprints. Go 1.18+ adopted the host's certificate verification framework, so it is necessary to alter a few things to continue to support thumbprint verification. * https://tip.golang.org/doc/go1.18 (search for "Certificate.Verify") * square/certigo#264
This patch updates the instances of $mktemp in the govc/test/*.bats files to support the macOS variant.
This patch fixes a few bugs related to the Namespaces API. There was an NPE occurring due to a pointer variable being used prior to being assigned. The "govc namespace.logs.download" command also just failed to work due to the VAPI client assuming the response will always be JSON and not possibly, binary data as one sends when one receives a tar file. Finally, the namespace.bats file used to use the cluster name "Workload-Cluster", but due to a hack in the simulated namespaces API, it only recognizes clusters that begin with "WCP".
1a44471 to
1ad33d4
Compare
Contributor
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the generated types to vSphere 8.0 GA and includes several other changes in order to support running tests locally on macOS 12.4:
govc about.certwas not respecting the-kflag (or env var) that disabled TLS verificationDialTLSContextinstead ofDialTLS, as the latter has been deprecated for multiple, major Go versions. TheDialTLSContextfunction refactors the logic related to thumbprint verification due to changes in Go 1.18+. For more information, please search forCertificate.Verifyin the Go 1.18 release notes$mktempin thegovc/test/*.batsfiles to support the macOS variant's flagsgovc namespace.logs.downloadwas just broken due to:tarfilenamespace.batsfile used to use the cluster nameWorkload-Cluster, but due to a hack in the simulated namespaces API, it only recognizes clusters that begin withWCP.Related issues:
Closes: NA
Type of change
Please mark options that are relevant:
not work as expected)
How Has This Been Tested?
make testSome tests related to vC Sim failed due to the nginx container used and running them on Apple Silicon. Allowing the PR's GitHub actions to validate the PR the rest of the way.
Checklist:
CONTRIBUTIONguidelines of this project