Skip to content

chore: remove dead sed strip from update-homebrew CI job#60

Merged
vmvarela merged 1 commit intomasterfrom
issue-59/remove-dead-sed-homebrew
Mar 14, 2026
Merged

chore: remove dead sed strip from update-homebrew CI job#60
vmvarela merged 1 commit intomasterfrom
issue-59/remove-dead-sed-homebrew

Conversation

@vmvarela
Copy link
Owner

Summary

Closes #59

Removes the dead sed -i 's/^ //' sql-pipe.rb from the update-homebrew job. The heredoc uses a quoted delimiter (<<'FORMULA'), so the sed pattern never matched anything — identical to the no-op removed from AUR (PR #58), Nix, and Scoop (PR #56).

Definition of Done

  • Dead sed line and comment removed
  • zig build test + ziglint pass
  • Self-reviewed

The heredoc uses a quoted delimiter (<<'FORMULA') which suppresses
variable expansion, but also means the file is written with literal
indentation — so sed 's/^          //' was always a no-op.

Same fix applied to Nix/Scoop in PR #56 and AUR in PR #58.

Closes #59
@vmvarela vmvarela merged commit a707a97 into master Mar 14, 2026
6 checks passed
@github-actions github-actions bot added the type:chore Maintenance, refactoring, tooling label Mar 14, 2026
@vmvarela vmvarela deleted the issue-59/remove-dead-sed-homebrew branch March 14, 2026 21:28
@vmvarela vmvarela mentioned this pull request Mar 14, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:chore Maintenance, refactoring, tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove dead sed strip in update-homebrew CI job

1 participant