[Model Runner V2] Fix test_spec_decode_acceptance_length Acceptance length regression#43685
Closed
yewentao256 wants to merge 1 commit into
Closed
[Model Runner V2] Fix test_spec_decode_acceptance_length Acceptance length regression#43685yewentao256 wants to merge 1 commit into
test_spec_decode_acceptance_length Acceptance length regression#43685yewentao256 wants to merge 1 commit into
Conversation
Signed-off-by: yewentao256 <zhyanwentao@126.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request defers the KV connector finalization in the GPU model runner until the drafter has written its KV cache. This is achieved by storing the scheduler output in _deferred_kv_connector_scheduler_output during execute_model under specific conditions (last PP rank, speculator present, and not a dummy run) and executing the post-forward step during sample_tokens. There are no review comments to address, and I have no additional feedback to provide.
30 tasks
Member
|
Thanks @yewentao256! I included this in a slightly bigger refactor in #43719, included you as co-author. |
yewentao256
commented
May 27, 2026
yewentao256
left a comment
Member
Author
There was a problem hiding this comment.
Close this PR as #43719 landed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Part of #41286
Fixes https://buildkite.com/vllm/ci/builds/67897#019e5781-68a4-4544-a7c6-04ba535ea293
VLLM_USE_V2_MODEL_RUNNER=1 bash tests/v1/kv_connector/nixl_integration/spec_decode_acceptance_test.shOriginally
Now
================== 1 passed, 16 warnings in 97.33s (0:01:37) ==================This PR fixes the issue (the drafter doesn't get the kv correctly)
For eagle3 + kv connector, we did it in an order like
pre_forward -> target forward -> post_forward -> speculator.proposeThis makes the drafter can't get the correct kv.We now do it in order as
pre_forward -> target forward -> speculator.propose -> post_forward