Skip to content

[CI] [Flaky] Avoid remote default model config in compile tests#42137

Open
SoluMilken wants to merge 1 commit into
vllm-project:mainfrom
SoluMilken:fix/compile-tests-local-model-config
Open

[CI] [Flaky] Avoid remote default model config in compile tests#42137
SoluMilken wants to merge 1 commit into
vllm-project:mainfrom
SoluMilken:fix/compile-tests-local-model-config

Conversation

@SoluMilken

@SoluMilken SoluMilken commented May 9, 2026

Copy link
Copy Markdown
Contributor

Purpose

Error message

[2026-05-09T02:23:49Z] FAILED compile/passes/test_qk_norm_rope_fusion.py::test_qk_norm_rope_fusion[dtype0-True-True-True-1e-06-False] - pydantic_core._pydantic_core.ValidationError: 1 validation error for ModelConfig
[2026-05-09T02:23:49Z]   Value error, Unrecognized model in Qwen/Qwen3-0.6B. Should have a `model_type` key in its config.json. [type=value_error, input_value=ArgsKwargs((), {'dtype': torch.bfloat16}), input_type=ArgsKwargs]
[2026-05-09T02:23:49Z]     For further information visit https://errors.pydantic.dev/2.12/v/value_error

Root Cause

Some compile pass tests only need model metadata for hand-written test modules, but ModelConfig(dtype=dtype) silently falls back to the default Hugging Face model (Qwen/Qwen3-0.6B). That makes the tests depend on implicit HF config / tokenizer behavior even though they are not testing model loading.

Code Change

  • Add local compile-test model metadata fixtures for Qwen3 and Llama.
  • Use the Qwen3 fixture for non-distributed compile tests that only need generic
    ModelConfig metadata.
  • Use the Llama fixture for distributed compile tests that previously used
    RedHatAI/Llama-3.2-1B-Instruct-FP8 only as fake metadata.
  • Skip tokenizer initialization so these tests do not depend on HF downloads,
    tokenizer files, or ModelConfig defaults.

Test Plan

python -m pytest -q \
  tests/compile/passes/test_qk_norm_rope_fusion.py \
  tests/compile/passes/test_functionalization.py \
  tests/compile/passes/test_fusion.py \
  tests/compile/passes/test_pass_manager.py \
  tests/compile/test_rotary_embedding_compile.py \
  --tb=short --disable-warnings

Test Result

image
Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the compilation tests by introducing local model configuration fixtures for Qwen3 and Llama models. It replaces hardcoded model names and default ModelConfig instantiations with these fixtures, ensuring that tests use minimal local metadata and skip unnecessary tokenizer initialization. I have no feedback to provide.

@SoluMilken SoluMilken force-pushed the fix/compile-tests-local-model-config branch from 5e8d47c to 4ce9ea3 Compare May 9, 2026 06:46
Signed-off-by: SoluMilken <ypiheyn.imm02g@g2.nctu.edu.tw>
@SoluMilken SoluMilken force-pushed the fix/compile-tests-local-model-config branch from 4ce9ea3 to 03e8310 Compare May 9, 2026 07:03
@SoluMilken SoluMilken marked this pull request as ready for review May 9, 2026 07:18

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@SoluMilken

Copy link
Copy Markdown
Contributor Author

@zou3519 @ProExpertProg @vadiklyutiy could one of you help add the ready label to trigger full CI? Thanks.

@SoluMilken SoluMilken changed the title [CI] Avoid remote default model config in compile tests [CI] [Flaky] Avoid remote default model config in compile tests May 9, 2026
@mergify

mergify Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @SoluMilken.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify Bot added the needs-rebase label May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant