[CI] [Flaky] Avoid remote default model config in compile tests#42137
Open
SoluMilken wants to merge 1 commit into
Open
[CI] [Flaky] Avoid remote default model config in compile tests#42137SoluMilken wants to merge 1 commit into
SoluMilken wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the compilation tests by introducing local model configuration fixtures for Qwen3 and Llama models. It replaces hardcoded model names and default ModelConfig instantiations with these fixtures, ensuring that tests use minimal local metadata and skip unnecessary tokenizer initialization. I have no feedback to provide.
5e8d47c to
4ce9ea3
Compare
Signed-off-by: SoluMilken <ypiheyn.imm02g@g2.nctu.edu.tw>
4ce9ea3 to
03e8310
Compare
Contributor
Author
|
@zou3519 @ProExpertProg @vadiklyutiy could one of you help add the |
Merged
4 tasks
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
buildkite/ci/pytorch-compilation-passes-unit-testsError message
Root Cause
Some compile pass tests only need model metadata for hand-written test modules, but
ModelConfig(dtype=dtype)silently falls back to the default Hugging Face model (Qwen/Qwen3-0.6B). That makes the tests depend on implicit HF config / tokenizer behavior even though they are not testing model loading.Code Change
ModelConfig metadata.
RedHatAI/Llama-3.2-1B-Instruct-FP8 only as fake metadata.
tokenizer files, or ModelConfig defaults.
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.