[MoE] Move aiter experts to fused_moe/experts/#41981
Closed
bnellnm wants to merge 6 commits into
Closed
Conversation
Rename rocm_aiter_fused_moe.py to experts/rocm_aiter_moe.py and update all references. Also fix stale docs pointer for grouped_topk after its earlier move to router/. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Jackmin801 <ongjackm@gmail.com>
…xperts Signed-off-by: Jackmin801 <ongjackm@gmail.com> # Conflicts: # vllm/model_executor/layers/fused_moe/__init__.py
…erts Signed-off-by: Bill Nell <bnell@redhat.com>
Contributor
|
Documentation preview: https://vllm--41981.org.readthedocs.build/en/41981/ |
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the ROCm Aiter MoE implementation by moving components from the top-level fused_moe directory into specialized experts and router subdirectories. The changes include updating import paths across the model executor, quantization layers, tests, and design documentation. I have no feedback to provide.
4 tasks
Collaborator
Author
|
Combined into one PR #41979 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Rename rocm_aiter_fused_moe.py to experts/rocm_aiter_moe.py and update all references. Also fix stale docs pointer for grouped_topk after its earlier move to router/.
Forked from #40573
cc: @Jackmin801 , @robertgshaw2-redhat
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.