Skip to content

[MoE] Move marlin moe to fused_moe/experts/#40572

Open
Jackmin801 wants to merge 7 commits into
vllm-project:mainfrom
Jackmin801:move-marlin-moe-to-experts
Open

[MoE] Move marlin moe to fused_moe/experts/#40572
Jackmin801 wants to merge 7 commits into
vllm-project:mainfrom
Jackmin801:move-marlin-moe-to-experts

Conversation

@Jackmin801

Copy link
Copy Markdown
Contributor

Rename fused_marlin_moe.py to experts/marlin_moe.py and update all references across the codebase (source, tests, docs).

Test plan

  • pytest -vs tests/kernels/moe

AI assistance was used to generate this change.

Rename fused_marlin_moe.py to experts/marlin_moe.py and update all
references across the codebase (source, tests, docs).

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Jackmin801 <ongjackm@gmail.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@mergify

mergify Bot commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

Documentation preview: https://vllm--40572.org.readthedocs.build/en/40572/

@mergify mergify Bot added documentation Improvements or additions to documentation nvidia labels Apr 22, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the project structure by moving the Marlin MoE kernel implementation from vllm/model_executor/layers/fused_moe/fused_marlin_moe.py to vllm/model_executor/layers/fused_moe/experts/marlin_moe.py. All associated import statements in the documentation, tests, and various quantization layers have been updated to reflect this new path. I have no feedback to provide as the changes are consistent and correctly implement the structural reorganization.

@Jackmin801 Jackmin801 mentioned this pull request Apr 22, 2026
1 task
@robertgshaw2-redhat robertgshaw2-redhat added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 23, 2026
@github-project-automation github-project-automation Bot moved this to Ready in NVIDIA Apr 23, 2026
@mergify

mergify Bot commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @Jackmin801.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify Bot added the needs-rebase label Apr 23, 2026
Signed-off-by: Robert Shaw <robertgshaw2@gmail.com>
Signed-off-by: Robert Shaw <robertgshaw2@gmail.com>
@mergify mergify Bot removed the needs-rebase label Apr 23, 2026
robertgshaw2-redhat and others added 2 commits April 23, 2026 13:40
…experts

Signed-off-by: Jackmin801 <ongjackm@gmail.com>

# Conflicts:
#	vllm/lora/layers/fused_moe.py
@mergify

mergify Bot commented May 23, 2026

Copy link
Copy Markdown
Contributor

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @Jackmin801.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify Bot added the needs-rebase label May 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation needs-rebase nvidia ready ONLY add when PR is ready to merge/full CI is needed

Projects

Status: Ready

Development

Successfully merging this pull request may close these issues.

3 participants