👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Directly adding the .so file here may not be the best way to patch. Can we figure out a way to download the file also explain how to patch the file in which scenario?

The file is used in place of the existing .so that is in the docker that is to be used. Without this particular version of libamdhip64.so the current llm-d function will not work.

There might be other ways to make this work, but the first step for now is to add it directly into this repository so that the docker installation can simply copy the library from the repository itself and into the final destination in the docker direclty.

There might be other ways to make this work, but the first step for now is to add it directly into this repository so that the docker installation can simply copy the library from the repository itself and into the final destination in the docker direclty.

I don't think we should put binaries in the vllm repo.