math: add tau constant, add factorial function #703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Value of Tau constant added Factorial function added, Tau constant added Factorial function added Factorial function made public Code cleaned
Member
|
Hey None of major languages have factorials in the stdlib. Tau is fine. |
Contributor
Author
|
Python does have a factorial function in its math module. (math module docs) |
Member
|
Indeed it does. Ok, can you make it return i64 and use for ;; loop? |
Contributor
Author
|
Done! |
elimisteve
reviewed
Jun 27, 2019
| pub fn factorial(a int) i64 { | ||
| mut prod := 1 | ||
| for i:= 0; i < a; i++ { | ||
| prod = prod * (i+1) |
Contributor
There was a problem hiding this comment.
Using i := 1 would be more efficient.
ntrel
reviewed
Jun 28, 2019
Contributor
ntrel
left a comment
There was a problem hiding this comment.
This should panic if a! is bigger than i64.max.
| pub fn factorial(a int) i64 { | ||
| mut prod := 1 | ||
| for i:= 0; i < a; i++ { | ||
| prod = prod * (i+1) |
Contributor
There was a problem hiding this comment.
Using i := 1 would be more efficient.
Contributor
|
@medvednikov maybe leave pulls open a bit longer for reviews ;-) |
ntrel
reviewed
Jun 28, 2019
Contributor
ntrel
left a comment
There was a problem hiding this comment.
This also needs to panic when a < 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! New to contributing so sorry for any errors in committing.
Added the Tau constant which is the ratio of a circle's circumference to its radius (2 * Pi)
Added the factorial function that calculates the factorial of an integer