Skip to content

docs: mention file-based attachments are not included in blob report and update CI example#9641

Merged
sheremet-va merged 3 commits intovitest-dev:mainfrom
hi-ogawa:docs/blob-attachments-merge-reports
Feb 12, 2026
Merged

docs: mention file-based attachments are not included in blob report and update CI example#9641
sheremet-va merged 3 commits intovitest-dev:mainfrom
hi-ogawa:docs/blob-attachments-merge-reports

Conversation

@hi-ogawa
Copy link
Copy Markdown
Collaborator

@hi-ogawa hi-ogawa commented Feb 12, 2026 •
edited
Loading

Description

Currently following fails since blob report doesn't include file attachments, but html reporter expects them to exist.

$ vitest --run --reporter=blob
$ rm .vitest-attachments
$ vitest --run --merge-report --reporter=html

I'm not sure if blob reporter should be self-contained with attachments, but for CI workflow, this can be easily adjusted with extra upload/download-artifact steps, so this PR just updates docs.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@hi-ogawa hi-ogawa changed the title docs: mention file-based attachments are not included in blob report and update blob reporter CI example docs: mention file-based attachments are not included in blob report and update CI example Feb 12, 2026
@netlify
Copy link
Copy Markdown

netlify bot commented Feb 12, 2026

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 17798da
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/698d6aed6825600008427398
😎 Deploy Preview https://deploy-preview-9641--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hi-ogawa hi-ogawa marked this pull request as ready for review February 12, 2026 06:02
@hi-ogawa hi-ogawa mentioned this pull request Feb 12, 2026
Closed
6 tasks
@sheremet-va
Copy link
Copy Markdown
Member

sheremet-va commented Feb 12, 2026 •
edited
Loading

Should they be include it though?

@hi-ogawa
Copy link
Copy Markdown
Collaborator Author

hi-ogawa commented Feb 12, 2026

I expected blob report being self-contained (i.e. include attachments) and I think it should. But realized current blob.json format shouldn't probably do that, so worth revising the blob format as zip or something in the future.

@sheremet-va
Copy link
Copy Markdown
Member

sheremet-va commented Feb 12, 2026 •
edited
Loading

I expected blob report being self-contained (i.e. include attachments) and I think it should. But realized current blob.json format shouldn't probably do that, so worth revising the blob format as zip or something in the future.

I agree, should we make an issue to track it?

@hi-ogawa hi-ogawa mentioned this pull request Feb 12, 2026
Merged
@hi-ogawa
Copy link
Copy Markdown
Collaborator Author

hi-ogawa commented Feb 12, 2026

Hmm, I was writing feature request and I realized CI pipeline doesn't need to change if attachments lives inside .vitest-report/.vitest-attachments 🤔

@hi-ogawa hi-ogawa mentioned this pull request Feb 12, 2026
Open
4 tasks
@sheremet-va sheremet-va merged commit c0c0ebc into vitest-dev:main Feb 12, 2026
10 checks passed
@hi-ogawa hi-ogawa deleted the docs/blob-attachments-merge-reports branch February 12, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sheremet-va sheremet-va sheremet-va approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hi-ogawa @sheremet-va