refactor: copy attachmentsDir in html reporter output#9632
Merged
sheremet-va merged 5 commits intovitest-dev:mainfrom Feb 12, 2026
Merged
Conversation
The explorer sidebar uses RecycleScroller which only renders items within the viewport. With more test fixtures, some items were not rendered at the default 720px height, causing locator failures. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Closed
6 tasks
sheremet-va
requested changes
Feb 11, 2026
Member
sheremet-va
left a comment
There was a problem hiding this comment.
What if attachment has a custom path?
Collaborator
Author
What is a custom path? Doesn't Vitest copy all inside |
Member
Hm, you are right, it just copies it into attachmentsDir |
sheremet-va
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I wasn't sure html reporter needs to traverse each attachment. This simplifies it by simple copy of
attachmentsDir. Also keepattachment.bodyfor data url on UI. The test case is added to verify it (though there's minor bug as per #9633).As indicated in TODO, eventually I'm looking into unify
attachmentsDirand htmloutputFile, so no copy is needed from html reporter side.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.