feat: conditional judgment for deleting the "html" reporter#9282
Closed
travzhang wants to merge 2 commits intovitest-dev:mainfrom
Closed
feat: conditional judgment for deleting the "html" reporter#9282travzhang wants to merge 2 commits intovitest-dev:mainfrom
travzhang wants to merge 2 commits intovitest-dev:mainfrom
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
Yes, but this closed issue still fails to fix the problem. |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the hard dependency on the built-in
htmlcoverage reporter when resolving the coverage HTML folder exposed by the Vitest API server.Previously, the coverage UI was only enabled when the
htmlreporter was explicitly configured. This assumption prevents custom or third-party coverage reporters from exposing valid HTML coverage output through the Vitest server, even when they generate static HTML reports.With this change, Vitest determines whether to expose the coverage folder based on coverage configuration and resolved output paths, rather than relying on the reporter name. This makes the behavior more flexible and allows custom HTML-based coverage reporters to integrate with the Vitest UI without needing to masquerade as the built-in
htmlreporter.Additional Context
This change is backward compatible with the existing
htmlreporter behavior and does not alter the default coverage directory structure. It only relaxes the reporter-type constraint to improve extensibility for custom coverage reporters.Tests
pnpm test:ci.Checklist
pnpm-lock.yaml.