fix(node): handle dependency stack traces with external source maps in non-browser mode#9047
Closed
iclectic wants to merge 7 commits intovitest-dev:mainfrom
Closed
fix(node): handle dependency stack traces with external source maps in non-browser mode#9047iclectic wants to merge 7 commits intovitest-dev:mainfrom
iclectic wants to merge 7 commits intovitest-dev:mainfrom
Conversation
…n non-browser mode Fixes #9003 (non-browser mode) The previous fix in 57ea647 only addressed browser mode. This PR extends the fix to non-browser mode (threads, forks, vmThreads) by: - Adding getSourceMap option to non-browser parseErrorStacktrace calls - Creating retrieveSourceMapURL helper to extract source map URLs - Adding logic to read external source map files from disk - Handling missing source maps gracefully with try-catch - Adding comprehensive tests across all execution modes
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
sheremet-va
requested changes
Nov 18, 2025
packages/vitest/src/node/test-run.ts
Outdated
| } | ||
| } | ||
|
|
||
| function retrieveSourceMapURL(source: string): string | null { |
Member
There was a problem hiding this comment.
If we merge this PR, this function will be defined 4 times. Can't you just export it from some util and use it?
Contributor
Author
|
I have incorporated the feedback by extracting the retrieveSourceMapURL function into a shared utility within @vitest/utils/source-map. Summary of Updates
About the CI Failures
Dependency trust error
Everything introduced in this PR has been validated locally and behaves as expected. |
hi-ogawa
reviewed
Nov 25, 2025
| expect(stderr).not.toContain('FAIL') | ||
| }) | ||
|
|
||
| test('should parse stack traces with external source maps in error output', async () => { |
Collaborator
There was a problem hiding this comment.
Can you explain how this test case is testing external library's source map? It looks like it's importing as user's file via import './bundled-lib.js'.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #9003
Changes
Tests
Related
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
Changesets
fix:prefix for automatic changelog generation.