Skip to content

fix: show the assertion error first when expect.poll assertion fails#8483

Merged
sheremet-va merged 2 commits intovitest-dev:mainfrom
sheremet-va:feat/print-error-poll-instead-timeout
Aug 28, 2025
Merged

fix: show the assertion error first when expect.poll assertion fails#8483
sheremet-va merged 2 commits intovitest-dev:mainfrom
sheremet-va:feat/print-error-poll-instead-timeout

Conversation

@sheremet-va
Copy link
Member

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Aug 26, 2025

Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 1f2bf36
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/68adb688cd43090008dc3b78
😎 Deploy Preview https://deploy-preview-8483--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sheremet-va sheremet-va requested a review from hi-ogawa August 27, 2025 10:32
@sheremet-va sheremet-va merged commit fb4500b into vitest-dev:main Aug 28, 2025
11 of 14 checks passed
@sheremet-va sheremet-va deleted the feat/print-error-poll-instead-timeout branch August 28, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants