fix(vitest): override config.include option with config.browser.instances[].include option if it is specified#8260
Merged
sheremet-va merged 2 commits intovitest-dev:mainfrom Aug 4, 2025
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
f83b803 to
f454f39
Compare
sheremet-va
requested changes
Jul 14, 2025
Member
sheremet-va
left a comment
There was a problem hiding this comment.
LGTM! Let's also apply this to exclude and includeSource
| instances: undefined, // projects cannot spawn more configs | ||
| }, | ||
| // If there is no include pattern in browser.instances[], we should use the include pattern from the parent project | ||
| include: (overrideConfig.include && overrideConfig.include.length > 0) ? [] : clonedConfig.include, |
Member
There was a problem hiding this comment.
Let's also have exclude and includeSource here, they usually all go together as a single source of test files
…stances[].include` option if it is specified
…` option within `config.browser.instances[]` option if it is specified
3ec9ef0 to
d59b896
Compare
sheremet-va
approved these changes
Aug 4, 2025
This was referenced Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Close: #7914
Hi Team 👋
As described in #7914 (comment), I understand that #7914 happens because
mergeConfigmerges array in config object instead of overriding it.As mentioned in docs, vitest config root's
includeoption has['**/*.{test,spec}.?(c|m)[jt]s?(x)']as default value, and config which is calculated per browser instance configuration will be like below:and so,
'**/*.{test,spec}.?(c|m)[jt]s?(x)'pattern in firefox's config will match test files which should be ignored byconfig.browsers.instances[firefox].include.I thought vitest user expect include config in deeper will be prioritized than the root that, so I fixed this issue by ignoreing project root's include value if
config.browser.instances[].includeis specified.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.