fix(coverage): browser + v8 in source tests missing#7946
Merged
sheremet-va merged 2 commits intovitest-dev:mainfrom May 23, 2025
Merged
fix(coverage): browser + v8 in source tests missing#7946sheremet-va merged 2 commits intovitest-dev:mainfrom
sheremet-va merged 2 commits intovitest-dev:mainfrom
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
528b7af to
21a2dad
Compare
AriPerkkio
commented
May 15, 2025
Comment on lines
-74
to
-77
| if (coverage.url.includes('?browserv=') || coverage.url.includes('&browserv=')) { | ||
| return false | ||
| } | ||
|
|
Member
Author
There was a problem hiding this comment.
Need to check with Storybook folks to see that this doesn't break coverage reports there. This was used to exclude *.stories.* from appearing in coverage report.
Member
Author
There was a problem hiding this comment.
*.stories.* are now visible on coverage report 😢
Member
There was a problem hiding this comment.
Storybook can now exclude story files inside the configureVitest hook
Member
Author
There was a problem hiding this comment.
Yep, that works! Using this in fresh Storybook project fixes the issue:
{
name: "exclude-stories",
configureVitest(context) {
if (context.vitest.config.coverage.enabled) {
context.vitest.config.coverage.exclude.push("**/*.stories.**");
}
},Related tests in #8009
6 tasks
@vitest/browser
@vitest/coverage-istanbul
@vitest/expect
@vitest/coverage-v8
@vitest/mocker
@vitest/pretty-format
@vitest/runner
@vitest/spy
@vitest/snapshot
@vitest/ui
@vitest/utils
vite-node
vitest
@vitest/web-worker
@vitest/ws-client
commit: |
21a2dad to
c5e4c24
Compare
AriPerkkio
commented
May 21, 2025
| const project = parentServer.vitest.getProjectByName(parentServer.config.name) | ||
| if (!project._isCachedTestFile(id) || !code.includes('import.meta.vitest')) { | ||
|
|
||
| if (!project._isCachedTestFile(filename) || !code.includes('import.meta.vitest')) { |
Member
Author
There was a problem hiding this comment.
This change is needed so that /Users/x/vitest/test/coverage-test/fixtures/src/in-source.ts?import&browserv=1747838764408 is recognized as cached test file.
sheremet-va
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.