fix(spy): copy over static properties from the function#7780
Merged
sheremet-va merged 12 commits intovitest-dev:mainfrom Jun 2, 2025
Merged
fix(spy): copy over static properties from the function#7780sheremet-va merged 12 commits intovitest-dev:mainfrom
sheremet-va merged 12 commits intovitest-dev:mainfrom
Conversation
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
Author
|
Tinyspy now always restores the original method correctly. The |
hi-ogawa
previously approved these changes
Apr 4, 2025
AriPerkkio
previously approved these changes
Apr 4, 2025
hi-ogawa
approved these changes
Jun 2, 2025
| expect(obj.property).toBe(true) | ||
| }) | ||
|
|
||
| it('respyin on a spy resets the counter', () => { |
Collaborator
There was a problem hiding this comment.
As long as this is working, it follows the expectation raised by #7348 (comment), so it looks safe to me. I cannot think of use cases where "spyOn multiple times" below causing issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6765
Fixes #7804
Fixes #7801
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.