fix: respect ssr.resolve.conditions on ssr environment#6993
Closed
sxzz wants to merge 2 commits intovitest-dev:mainfrom
Closed
fix: respect ssr.resolve.conditions on ssr environment#6993sxzz wants to merge 2 commits intovitest-dev:mainfrom
ssr.resolve.conditions on ssr environment#6993sxzz wants to merge 2 commits intovitest-dev:mainfrom
Conversation
resolve.conditions on ssr environment
sxzz
commented
Nov 30, 2024
Member
|
As I said in #6992 (comment) this is expected breaking change in Vite |
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
resolve.conditions on ssr environmentssr.resolve.conditions on ssr environment
Contributor
Author
|
@sheremet-va I just updated it to |
Contributor
|
Closing since this compat is implemented by Vite vitejs/vite#18857 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Respect
resolve.conditionsfor ssr env.closes #6992
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.