Skip to content

fix: Align RawMatcherFn type definition with Jest#6351

Merged
sheremet-va merged 1 commit intovitest-dev:mainfrom
wheresrhys:patch-1
Aug 19, 2024
Merged

fix: Align RawMatcherFn type definition with Jest#6351
sheremet-va merged 1 commit intovitest-dev:mainfrom
wheresrhys:patch-1

Conversation

@wheresrhys
Copy link
Contributor

@wheresrhys wheresrhys commented Aug 15, 2024 •
edited
Loading

Might fix #6350

Description

Copied the typedef from jest, which is a better reflection of the fact vitest does actually use spread

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it. N/A - change to types, not implementation
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci. N/A - change to types, not implementation

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@wheresrhys
Copy link
Contributor Author

wheresrhys commented Aug 15, 2024

I've tried debugging the build locally. Due to pnpm/volta clashes I've had to use pnpm@7, so I'm not sure how accurate my local results are.

However, I'm not seeing any failures that look relevant to my change - just lots of failures in test files (which I think is due to pnpm@7 failing to correctly resolve peer dependencies)

@sheremet-va
Copy link
Member

sheremet-va commented Aug 15, 2024

I've tried debugging the build locally. Due to pnpm/volta clashes I've had to use pnpm@7, so I'm not sure how accurate my local results are.

However, I'm not seeing any failures that look relevant to my change - just lots of failures in test files (which I think is due to pnpm@7 failing to correctly resolve peer dependencies)

Use corepack to enable pnpm.

The errors are related to your changes. If you can't debug locally, make changes based on errors in CI. They provide a line number and a column where the error is.

@netlify
Copy link

netlify bot commented Aug 15, 2024

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3baa949
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/66be5512e228ca0008cd9d20
😎 Deploy Preview https://deploy-preview-6351--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wheresrhys
Copy link
Contributor Author

wheresrhys commented Aug 15, 2024

Hopefully all good now

@wheresrhys wheresrhys changed the title Update types for RawMatcherFn to use spread fix: Align RawMatcherFn type definition with Jest Aug 15, 2024
@wheresrhys wheresrhys mentioned this pull request Aug 16, 2024
Merged
@sheremet-va sheremet-va merged commit d09f00c into vitest-dev:main Aug 19, 2024
@sheremet-va
Copy link
Member

sheremet-va commented Aug 19, 2024

thanks!

@renovate renovate bot mentioned this pull request Sep 15, 2024
Merged
1 task
This was referenced Oct 5, 2024
Open
Open
@Ramyromel Ramyromel mentioned this pull request Oct 5, 2024
Merged
@leonardoadame leonardoadame mentioned this pull request Oct 5, 2024
Open
@nerdy-tech-com-gitub nerdy-tech-com-gitub mentioned this pull request Oct 5, 2024
Open
@leonardoadame leonardoadame mentioned this pull request Oct 5, 2024
Open
This was referenced Oct 24, 2024
Open
Open
This was referenced Oct 25, 2024
Open
Open
Open
Open
This was referenced Oct 28, 2024
Open
Open
Open
@renovate renovate bot mentioned this pull request Oct 29, 2024
Closed
1 task
@leonardoadame leonardoadame mentioned this pull request Oct 30, 2024
Open
This was referenced Oct 30, 2024
Open
Open
@HaLaGu1L HaLaGu1L mentioned this pull request Nov 3, 2024
Open
This was referenced Nov 5, 2024
Open
Open
Open
Open
@nerdy-tech-com-gitub nerdy-tech-com-gitub mentioned this pull request Nov 6, 2024
Open
This was referenced Nov 6, 2024
Open
Open
Open
Open
@renovate renovate bot mentioned this pull request Feb 14, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sheremet-va sheremet-va sheremet-va approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support spread parameters for extensions [in types]

2 participants

@wheresrhys @sheremet-va