Skip to content

fix: testNamePattern adds leading space#6186

Merged
sheremet-va merged 1 commit intovitest-dev:mainfrom
AriPerkkio:fix/test-name-pattern-regexp
Jul 26, 2024
Merged

fix: testNamePattern adds leading space#6186
sheremet-va merged 1 commit intovitest-dev:mainfrom
AriPerkkio:fix/test-name-pattern-regexp

Conversation

@AriPerkkio
Copy link
Member

@AriPerkkio AriPerkkio commented Jul 21, 2024 •
edited
Loading

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@AriPerkkio AriPerkkio force-pushed the fix/test-name-pattern-regexp branch from e41c07c to 60a299b Compare July 21, 2024 18:43
sheremet-va
sheremet-va reviewed Jul 21, 2024
View reviewed changes
@AriPerkkio AriPerkkio force-pushed the fix/test-name-pattern-regexp branch from 5bfc1f4 to 1777553 Compare July 26, 2024 05:20
@netlify
Copy link

netlify bot commented Jul 26, 2024

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1777553
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/66a33231d563720008cf0e35
😎 Deploy Preview https://deploy-preview-6186--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sheremet-va sheremet-va merged commit 073a50c into vitest-dev:main Jul 26, 2024
This was referenced Aug 21, 2024
Open
Open
Open
Open
This was referenced Aug 28, 2024
Open
Open
@leonardoadame leonardoadame mentioned this pull request Sep 10, 2024
Open
This was referenced Sep 10, 2024
Merged
Merged
@leonardoadame leonardoadame mentioned this pull request Sep 11, 2024
Open
@Ramyromel Ramyromel mentioned this pull request Sep 15, 2024
Open
This was referenced Sep 18, 2024
Open
Open
Open
Open
Open
Open
@gr00nd gr00nd mentioned this pull request Sep 23, 2024
Open
@renovate renovate bot mentioned this pull request Sep 26, 2024
Closed
1 task
@leonardoadame leonardoadame mentioned this pull request Sep 28, 2024
Open
@renovate renovate bot mentioned this pull request Oct 14, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sheremet-va sheremet-va sheremet-va approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: testNamePattern option unnecessarily requires a leading space for an exact match.

2 participants

@AriPerkkio @sheremet-va