test: standardising internal test#5600
Merged
sheremet-va merged 73 commits intovitest-dev:mainfrom Apr 26, 2024
Merged
Conversation
✅ Deploy Preview for fastidious-cascaron-4ded94 canceled.
|
05a578f to
66d1e71
Compare
Contributor
|
Awesome! I agree with the change. I also felt like most of the tests can go to |
AriPerkkio
previously approved these changes
Apr 26, 2024
Member
AriPerkkio
left a comment
There was a problem hiding this comment.
Looks good, thanks!
We should probably move all static fixtures (like those 4x math.test.ts) under test/test-utils at some point.
hi-ogawa
reviewed
Apr 26, 2024
cc534f2 to
b034b76
Compare
sapphi-red
reviewed
Apr 27, 2024
| "publish-ci": "tsx scripts/publish-ci.ts", | ||
| "release": "bumpp package.json packages/*/package.json --commit --push --tag && git update-ref refs/heads/release refs/heads/main && git push origin release", | ||
| "test": "vitest --api -r test/core", | ||
| "test:run": "vitest run -r test/core", |
Contributor
There was a problem hiding this comment.
@sheremet-va test:run was used by ecosystem-ci. Would you put it back or update the script in ecosystem-ci?
https://github.com/vitejs/vite-ecosystem-ci/blob/c88b8726c07c04e690c854457f60adf840223669/tests/vitest.ts#L9
This was referenced Jun 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes some small test packages, and moves tests from them into cli/config or core, if applicable.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.