fix(vitest): delegate snapshot options to workspace from root config#5199
Merged
sheremet-va merged 7 commits intovitest-dev:mainfrom Feb 16, 2024
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
vitest run --updatedoesn't work for workspaces #5194Since
SnapshotManageris a singleton managed by mainVitestinstance, I thinkWorkspaceProject.getSerializableConfigneeds to use the same options as:vitest/packages/vitest/src/node/core.ts
Line 101 in ec55fdd
I expect snapshot options to do something similar to coverage options, which is also root config only options:
vitest/packages/vitest/src/node/workspace.ts
Line 332 in ec55fdd
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.