Skip to content

fix(vitest): delegate snapshot options to workspace from root config#5199

Merged
sheremet-va merged 7 commits intovitest-dev:mainfrom
hi-ogawa:fix-workspace-snapshot-options
Feb 16, 2024
Merged

fix(vitest): delegate snapshot options to workspace from root config#5199
sheremet-va merged 7 commits intovitest-dev:mainfrom
hi-ogawa:fix-workspace-snapshot-options

Conversation

@hi-ogawa
Copy link
Copy Markdown
Collaborator

@hi-ogawa hi-ogawa commented Feb 14, 2024

Description

Since SnapshotManager is a singleton managed by main Vitest instance, I think WorkspaceProject.getSerializableConfig needs to use the same options as:

this.snapshot = new SnapshotManager({ ...resolved.snapshotOptions })

I expect snapshot options to do something similar to coverage options, which is also root config only options:

coverage: this.ctx.config.coverage,

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vitest run --update doesn't work for workspaces

2 participants