Skip to content

fix(utils): fix asymmetric matcher diff inside array#5189

Merged
sheremet-va merged 2 commits intovitest-dev:mainfrom
hi-ogawa:fix-any-replacement-before-diff
Feb 13, 2024
Merged

fix(utils): fix asymmetric matcher diff inside array#5189
sheremet-va merged 2 commits intovitest-dev:mainfrom
hi-ogawa:fix-any-replacement-before-diff

Conversation

@hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Feb 13, 2024

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Feb 13, 2024

Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name Link
🔨 Latest commit 8a8359d
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/65cafcf1e8f2c700087fcea4

@hi-ogawa hi-ogawa changed the title fix(utils): fix assymetric matcher diff with array fix(utils): fix asymmetric matcher diff with array Feb 13, 2024
@hi-ogawa hi-ogawa changed the title fix(utils): fix asymmetric matcher diff with array fix(utils): fix asymmetric matcher diff inside array Feb 13, 2024
@hi-ogawa hi-ogawa marked this pull request as ready for review February 13, 2024 05:39
@sheremet-va sheremet-va merged commit 3ffcd2e into vitest-dev:main Feb 13, 2024
@hi-ogawa hi-ogawa deleted the fix-any-replacement-before-diff branch February 13, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong diff for expect([0, ""]).toEqual([1, expect.anything()])

2 participants