@AriPerkkio do you think we should add watermarks to CLI options? With the new transform option we can define it as --coverage.watermarks=10,30 for example

✅ Deploy Preview for fastidious-cascaron-4ded94 ready!

Name	Link
🔨 Latest commit	92983c4
🔍 Latest deploy log	https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/65c742308399db0008dba263
😎 Deploy Preview	https://deploy-preview-5163--fastidious-cascaron-4ded94.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

do you think we should add watermarks to CLI options? With the new transform option we can define it as --coverage.watermarks=10,30 for example

If supporting it is not too difficult, then sure let's add it. So --coverage.watermarks.lines=10,20 --coverage.watermarks.functions=10,20 should be merged into:

{
  statements: [50, 80], // Default value
  functions: [10, 20],
  branches: [50, 80],   // Default value
  lines: [10, 20]
}

f supporting it is not too difficult, then sure let's add it. So --coverage.watermarks.lines=10,20 --coverage.watermarks.functions=10,20 should be merged into:

Do we need to merge them ourselves? Right now you can pass down lines and function in the config file and watermarks is not resolved to the full object.

Do we need to merge them ourselves?

Oh right - we don't need to worry about the defaults. Istanbul will merge these automatically with the default ones. So --coverage.watermarks.lines=10,20 --coverage.watermarks.functions=10,20 should produce following config in Vitest's perspective:

{
 functions: [10, 20],
 lines: [10, 20]
}