Skip to content

fix(reporters): testsuite name should include project root in Junit output#5116

Merged
sheremet-va merged 4 commits intovitest-dev:mainfrom
fenghan34:fix/junit-reporter
Feb 5, 2024
Merged

fix(reporters): testsuite name should include project root in Junit output#5116
sheremet-va merged 4 commits intovitest-dev:mainfrom
fenghan34:fix/junit-reporter

Conversation

@fenghan34
Copy link
Contributor

@fenghan34 fenghan34 commented Feb 5, 2024 •
edited
Loading

Description

Closes #5088.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Feb 5, 2024 •
edited
Loading

✅ Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name Link
🔨 Latest commit b317672
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/65c097b82ca0350008e94691

@fenghan34 fenghan34 changed the title fix(reporters): junit should print project root fix(reporters): testsuite name should include project root in Junit output Feb 5, 2024
@fenghan34 fenghan34 marked this pull request as ready for review February 5, 2024 08:29
@sheremet-va sheremet-va merged commit 2494fbf into vitest-dev:main Feb 5, 2024
@fenghan34 fenghan34 deleted the fix/junit-reporter branch February 5, 2024 12:29
@lsanwick lsanwick mentioned this pull request Feb 6, 2024
Closed
@sheremet-va sheremet-va added this to the 1.3.0 milestone Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AriPerkkio AriPerkkio AriPerkkio approved these changes

@sheremet-va sheremet-va sheremet-va approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.3.0

Development

Successfully merging this pull request may close these issues.

Junit reporter doesn't include project root in output

3 participants

@fenghan34 @AriPerkkio @sheremet-va