fix(browser): support coverage.reportsDirectory with multiple directories#5056
Merged
AriPerkkio merged 1 commit intovitest-dev:mainfrom Feb 2, 2024
Merged
Conversation
✅ Deploy Preview for fastidious-cascaron-4ded94 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Member
|
@AriPerkkio both client and server should be in sync: https://github.com/vitest-dev/vitest/blob/main/packages/ui/node/index.ts Check #3917 |
Member
Author
|
Are they currently in sync? Before this fix I see following with
In browser mode this Would the correct fix be to add this logic into vitest/packages/ui/node/index.ts Line 20 in d53b858 |
89e498d to
b57f074
Compare
Member
Author
|
Are there any existing test cases for browser's watch mode? I guess only UI has those e2e-tests? |
Member
|
We have a browser test in |
Member
Author
|
There are no existing test cases where this could be added easily. I've tried to build a new one into And now I'm again running into the case where browser mode picks non-existing test cases and fails: 
I'll try to verify these changes manually with multiple different configuration options once the error above stops showing up. But I'm not sure if adding a regression test is doable for now. |
6 tasks
userquin
previously approved these changes
Feb 2, 2024
Member
userquin
left a comment
There was a problem hiding this comment.
The logic seems to be the same included in the vitest:ui plugin
b57f074 to
9f29f05
Compare
Member
Author
|
I've now tested multiple different variations of About the error mentioned in #5056 (comment). This is something I've seen many times ever since browser mode was implemented. We've also seen this on CI. Browser mode seems to attempt to run test cases that do not belong to the current project that is being run. It includes test cases from previous browser mode runs. I'm starting to think there is some kind of 24h caching that causes this. When I ran into this bug this time, I tried removing all |
renovate bot
referenced
this pull request
in Johannes-Andersen/Johannes
Feb 16, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@vitest/coverage-v8](https://togithub.com/vitest-dev/vitest/tree/main/packages/coverage-v8#readme) ([source](https://togithub.com/vitest-dev/vitest/tree/HEAD/packages/coverage-v8)) | [`1.2.2` -> `1.3.0`](https://renovatebot.com/diffs/npm/@vitest%2fcoverage-v8/1.2.2/1.3.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [vitest](https://togithub.com/vitest-dev/vitest) ([source](https://togithub.com/vitest-dev/vitest/tree/HEAD/packages/vitest)) | [`1.2.2` -> `1.3.0`](https://renovatebot.com/diffs/npm/vitest/1.2.2/1.3.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vitest-dev/vitest (@​vitest/coverage-v8)</summary> ### [`v1.3.0`](https://togithub.com/vitest-dev/vitest/releases/tag/v1.3.0) [Compare Source](https://togithub.com/vitest-dev/vitest/compare/v1.2.2...v1.3.0) ##### 🚀 Features - Deprecate watchExclude - by [@​patak-dev](https://togithub.com/patak-dev) in [https://github.com/vitest-dev/vitest/issues/5171](https://togithub.com/vitest-dev/vitest/issues/5171) [<samp>(82885)</samp>](https://togithub.com/vitest-dev/vitest/commit/828858f8) - **browser**: - Run test files in isolated iframes - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5036](https://togithub.com/vitest-dev/vitest/issues/5036) [<samp>(4f401)</samp>](https://togithub.com/vitest-dev/vitest/commit/4f40177e) - **config**: - Add `snapshotSerializers` option - by [@​fenghan34](https://togithub.com/fenghan34) in [https://github.com/vitest-dev/vitest/issues/5092](https://togithub.com/vitest-dev/vitest/issues/5092) [<samp>(5b102)</samp>](https://togithub.com/vitest-dev/vitest/commit/5b1021da) - **reporters**: - Support custom options - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [https://github.com/vitest-dev/vitest/issues/5111](https://togithub.com/vitest-dev/vitest/issues/5111) [<samp>(fec9c)</samp>](https://togithub.com/vitest-dev/vitest/commit/fec9ca0b) - **runner**: - Support automatic fixtures - by [@​fenghan34](https://togithub.com/fenghan34) and [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5102](https://togithub.com/vitest-dev/vitest/issues/5102) [<samp>(0441f)</samp>](https://togithub.com/vitest-dev/vitest/commit/0441f761) - **ui**: - Save splitpanes size to local storage - by [@​posva](https://togithub.com/posva) in [https://github.com/vitest-dev/vitest/issues/5166](https://togithub.com/vitest-dev/vitest/issues/5166) [<samp>(c28b4)</samp>](https://togithub.com/vitest-dev/vitest/commit/c28b4c26) - **vitest**: - Add onTestFinished hook - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5128](https://togithub.com/vitest-dev/vitest/issues/5128) [<samp>(6f5b4)</samp>](https://togithub.com/vitest-dev/vitest/commit/6f5b42b7) - Add github actions reporter - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5093](https://togithub.com/vitest-dev/vitest/issues/5093) [<samp>(40afb)</samp>](https://togithub.com/vitest-dev/vitest/commit/40afbe3a) - Expose jsdom global if jsdom environment is enabled - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5155](https://togithub.com/vitest-dev/vitest/issues/5155) [<samp>(567d2)</samp>](https://togithub.com/vitest-dev/vitest/commit/567d20b9) - Add new CLI options - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5163](https://togithub.com/vitest-dev/vitest/issues/5163) [<samp>(4e179)</samp>](https://togithub.com/vitest-dev/vitest/commit/4e179426) - "test" accepts options object as the second parameter - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5142](https://togithub.com/vitest-dev/vitest/issues/5142) [<samp>(7d9b1)</samp>](https://togithub.com/vitest-dev/vitest/commit/7d9b1fb0) - **vm**: - Support wasm module - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5131](https://togithub.com/vitest-dev/vitest/issues/5131) [<samp>(5ed53)</samp>](https://togithub.com/vitest-dev/vitest/commit/5ed537f0) ##### 🐞 Bug Fixes - Fix sourcemap in vm pools - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5063](https://togithub.com/vitest-dev/vitest/issues/5063) [<samp>(81105)</samp>](https://togithub.com/vitest-dev/vitest/commit/8110540a) - Don't optimize react/jsx-runtime by default when running in Node - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5079](https://togithub.com/vitest-dev/vitest/issues/5079) [<samp>(0d2bf)</samp>](https://togithub.com/vitest-dev/vitest/commit/0d2bfeac) - Rpc timeout error messages to include caller - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [https://github.com/vitest-dev/vitest/issues/5103](https://togithub.com/vitest-dev/vitest/issues/5103) [<samp>(a6e04)</samp>](https://togithub.com/vitest-dev/vitest/commit/a6e04bd8) - Requires fixed version across the monorepo - by [@​antfu](https://togithub.com/antfu) in [https://github.com/vitest-dev/vitest/issues/5208](https://togithub.com/vitest-dev/vitest/issues/5208) [<samp>(68f51)</samp>](https://togithub.com/vitest-dev/vitest/commit/68f51961) - Prevent merging of `poolOptions` - by [@​penalosa](https://togithub.com/penalosa) in [https://github.com/vitest-dev/vitest/issues/5221](https://togithub.com/vitest-dev/vitest/issues/5221) [<samp>(bc5b2)</samp>](https://togithub.com/vitest-dev/vitest/commit/bc5b2d04) - **browser**: - Don't exclude node builtins from optimization - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5082](https://togithub.com/vitest-dev/vitest/issues/5082) [<samp>(714c9)</samp>](https://togithub.com/vitest-dev/vitest/commit/714c911f) - Support `coverage.reportsDirectory` with multiple directories - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [https://github.com/vitest-dev/vitest/issues/5056](https://togithub.com/vitest-dev/vitest/issues/5056) [<samp>(ae73f)</samp>](https://togithub.com/vitest-dev/vitest/commit/ae73f273) - **cli**: - Parse `--browser=<name>` correctly - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [https://github.com/vitest-dev/vitest/issues/5179](https://togithub.com/vitest-dev/vitest/issues/5179) [<samp>(656e2)</samp>](https://togithub.com/vitest-dev/vitest/commit/656e210b) - **coverage**: - `.tmp` directory conflicts with `--shard` option - by [@​AriPerkkio](https://togithub.com/AriPerkkio) in [https://github.com/vitest-dev/vitest/issues/5184](https://togithub.com/vitest-dev/vitest/issues/5184) [<samp>(5749d)</samp>](https://togithub.com/vitest-dev/vitest/commit/5749d2c2) - **deps**: - Update dependency strip-literal to v2 - by [@​renovate](https://togithub.com/renovate)\[bot] in[https://github.com/vitest-dev/vitest/issues/5136](https://togithub.com/vitest-dev/vitest/issues/5136)6 [<samp>(ef557)</samp>](https://togithub.com/vitest-dev/vitest/commit/ef557243) - **reporters**: - Testsuite name should include project root in Junit output - by [@​fenghan34](https://togithub.com/fenghan34) in [https://github.com/vitest-dev/vitest/issues/5116](https://togithub.com/vitest-dev/vitest/issues/5116) [<samp>(2494f)</samp>](https://togithub.com/vitest-dev/vitest/commit/2494fbf2) - **typecheck**: - Fix suite collection while-loop - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5065](https://togithub.com/vitest-dev/vitest/issues/5065) [<samp>(35675)</samp>](https://togithub.com/vitest-dev/vitest/commit/35675bd3) - **ui**: - Fix tests duration time - by [@​vovsemenv](https://togithub.com/vovsemenv) in [https://github.com/vitest-dev/vitest/issues/5219](https://togithub.com/vitest-dev/vitest/issues/5219) [<samp>(58103)</samp>](https://togithub.com/vitest-dev/vitest/commit/581030ee) - **utils**: - Fix asymmetric matcher diff inside array - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5189](https://togithub.com/vitest-dev/vitest/issues/5189) [<samp>(3ffcd)</samp>](https://togithub.com/vitest-dev/vitest/commit/3ffcd2ea) - **vitest**: - Correctly report failed test files as failures in json reporter, export json reporter types - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5081](https://togithub.com/vitest-dev/vitest/issues/5081) [<samp>(0417b)</samp>](https://togithub.com/vitest-dev/vitest/commit/0417ba20) - Don't run typecheck tests in browser if both are enabled - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5080](https://togithub.com/vitest-dev/vitest/issues/5080) [<samp>(1045b)</samp>](https://togithub.com/vitest-dev/vitest/commit/1045b98b) - Handle function config inside `defineWorkspace` - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5089](https://togithub.com/vitest-dev/vitest/issues/5089) [<samp>(0bf52)</samp>](https://togithub.com/vitest-dev/vitest/commit/0bf52533) - Remove excessive listeners when running without isolation, don't reset the state - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5132](https://togithub.com/vitest-dev/vitest/issues/5132) [<samp>(b607f)</samp>](https://togithub.com/vitest-dev/vitest/commit/b607f1ea) - Auto-enable "github-actions" only where users didn't configure reporters - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5158](https://togithub.com/vitest-dev/vitest/issues/5158) [<samp>(ef044)</samp>](https://togithub.com/vitest-dev/vitest/commit/ef0440cb) - Support more array cli options - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5162](https://togithub.com/vitest-dev/vitest/issues/5162) [<samp>(3afe6)</samp>](https://togithub.com/vitest-dev/vitest/commit/3afe68f1) - Add types for the new global `jsdom` variable - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5164](https://togithub.com/vitest-dev/vitest/issues/5164) [<samp>(0f898)</samp>](https://togithub.com/vitest-dev/vitest/commit/0f898d87) - Expose onTestFinished globally - by [@​sheremet-va](https://togithub.com/sheremet-va) [<samp>(1304f)</samp>](https://togithub.com/vitest-dev/vitest/commit/1304fed7) - Disable optimizer by default until it's stable - by [@​sheremet-va](https://togithub.com/sheremet-va) in [https://github.com/vitest-dev/vitest/issues/5156](https://togithub.com/vitest-dev/vitest/issues/5156) [<samp>(e1bd8)</samp>](https://togithub.com/vitest-dev/vitest/commit/e1bd8d5d) - Delegate snapshot options to workspace from root config - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5199](https://togithub.com/vitest-dev/vitest/issues/5199) [<samp>(86297)</samp>](https://togithub.com/vitest-dev/vitest/commit/86297d42) - Fix `optimizeDeps.disabled` warnings on Vite 5.1 - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5215](https://togithub.com/vitest-dev/vitest/issues/5215) [<samp>(1aecd)</samp>](https://togithub.com/vitest-dev/vitest/commit/1aecd650) - **vm**: - Handle `disableConsoleIntercept` config - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5074](https://togithub.com/vitest-dev/vitest/issues/5074) [<samp>(a55ad)</samp>](https://togithub.com/vitest-dev/vitest/commit/a55adac6) - Improve error when module is not found - by [@​hi-ogawa](https://togithub.com/hi-ogawa) in [https://github.com/vitest-dev/vitest/issues/5053](https://togithub.com/vitest-dev/vitest/issues/5053) [<samp>(79a50)</samp>](https://togithub.com/vitest-dev/vitest/commit/79a50c3f) ##### [View changes on GitHub](https://togithub.com/vitest-dev/vitest/compare/v1.2.2...v1.3.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Johannes-Andersen/Johannes). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.