Skip to content

fix(spy): don't allow Promise in mockImplementation#4859

Merged
sheremet-va merged 1 commit intovitest-dev:mainfrom
sheremet-va:fix/spy-promise
Jan 3, 2024
Merged

fix(spy): don't allow Promise in mockImplementation#4859
sheremet-va merged 1 commit intovitest-dev:mainfrom
sheremet-va:fix/spy-promise

Conversation

@sheremet-va
Copy link
Member

Description

Fixes #3750
Closes #3824

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Jan 3, 2024

Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name Link
🔨 Latest commit d3eb24e
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/659595b4f82526000816d499

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mocking implementation with mockImplementation allows incorrect return types

1 participant