fix(browser): fix browser testing url for https#4855
Merged
sheremet-va merged 24 commits intovitest-dev:mainfrom Jan 16, 2024
Merged
fix(browser): fix browser testing url for https#4855sheremet-va merged 24 commits intovitest-dev:mainfrom
sheremet-va merged 24 commits intovitest-dev:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #4844
I used
ViteDevServer.resolvedUrlsto grab the url for browser testing. I think this should be always available and If this is not available, then it's probably a Vite bug, so I didn't put any fallback or validation here.On a related note, currently Vite's, so I think treatingbaseconfig is not supported yet (as reported in #4686), butViteDevServer.resolvedUrlswill be also generated according tobaseconfigresolvedUrlsas a single source of truth is appropriate for browser testing.(Actually
basedoesn't change browser testing url since it's always root/, but I guess it would still make sense to useresolvedUrlsas a way to get origin.)Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.