fix: don't crash when memoryLimit is assumed to be a percentage of system memory#4802
Merged
AriPerkkio merged 3 commits intovitest-dev:mainfrom Jan 1, 2024
Merged
fix: don't crash when memoryLimit is assumed to be a percentage of system memory#4802AriPerkkio merged 3 commits intovitest-dev:mainfrom
AriPerkkio merged 3 commits intovitest-dev:mainfrom
Conversation
✅ Deploy Preview for fastidious-cascaron-4ded94 canceled.
|
Member
Can you give an example of a value that throws an error here? |
Contributor
Author
|
I'm sorry for not providing a specific example in the description earlier. Here is an example that throws an error when import { cpus } from 'os';
import { defineConfig } from 'vitest/config';
const cpuNum = Math.max(cpus().length - 1, 1);
export default defineConfig({
test: {
// ...other config
pool: 'vmThreads',
poolOptions: {
vmThreads: {
memoryLimit: Math.min(1 / (cpuNum * 2), 0.1),
},
},
},
}); |
Member
|
I can reproduce the crash. But now that I'm looking at I'll need to do some more debugging and testing before we can merge this. |
AriPerkkio
reviewed
Jan 1, 2024
AriPerkkio
reviewed
Jan 1, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When I upgraded vitest to version 1.1.0 and replaced the original
experimentalVmWorkerMemoryLimitconfig withpoolOptions.vmThreads.memoryLimit, an error occurred when runningpnpm test: "For a percentage based memory limit, a percentageReference must be provided."Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.