fix!(spy): simplify mock function generic types and align with jest#4784
Merged
sheremet-va merged 34 commits intovitest-dev:mainfrom Jun 23, 2024
Merged
fix!(spy): simplify mock function generic types and align with jest#4784sheremet-va merged 34 commits intovitest-dev:mainfrom
sheremet-va merged 34 commits intovitest-dev:mainfrom
Conversation
✅ Deploy Preview for fastidious-cascaron-4ded94 canceled.
|
Member
|
I don't think we should change base types yet. Instead, I propose defining a namespace with new mock types like vite does with Rollup namespace (naming can be discussed): // mock-types.ts
export type MockContext<T extends Procedure> = {}
// spy.ts
import type * as Mocks from './mock-types.ts'
export type { Mocks }
// test.ts
import type { Mocks } from 'vitest'
const fn: Mocks.Spy<() => void> = vi.fn() |
6 tasks
Contributor
Author
|
vitest/packages/spy/src/index.ts Lines 111 to 114 in c17bac0 |
Member
Sure, let's remove it. |
hi-ogawa
commented
Apr 23, 2024
This was referenced Jul 29, 2024
This was referenced Aug 5, 2024
This was referenced Aug 21, 2024
This was referenced Aug 28, 2024
This was referenced Sep 10, 2024
This was referenced Sep 23, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #4723
I started with a mostly straight-forward typing update by following jestjs/jest#12489. I will consider the implication of this change in details later.
todo
SpyInstance?vi.fndefault to(...args: any[]) => anyor(...args: unknown[]) => unknown?references
jest.fngeneric type arguments jestjs/jest#12489Mocked*utility types jestjs/jest#13123jest.mockedhelper’s behaviour to deep mocked jestjs/jest#13125jest.Spied*utility types jestjs/jest#13440Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.