Skip to content

fix(ui): escape html for console log view#4724

Merged
sheremet-va merged 7 commits intovitest-dev:mainfrom
hi-ogawa:fix-ui-log-escape-html
Dec 18, 2023
Merged

fix(ui): escape html for console log view#4724
sheremet-va merged 7 commits intovitest-dev:mainfrom
hi-ogawa:fix-ui-log-escape-html

Conversation

@hi-ogawa
Copy link
Copy Markdown
Collaborator

@hi-ogawa hi-ogawa commented Dec 11, 2023

Description

Closes #1279, #2765, #3934

I'm not sure if this naive idea is supposed to work (or already attempted before) but this is just to start investigation and I will test it further.

At least this filter.toHtml(escapeHtml(...)) pattern seems to be already used in report view:

htmlError = `<b>${error.nameStr || error.name}</b>: ${filter.toHtml(escapeHtml(error.message))}`

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vitest UI doesn't log html correctly in the "console log" tab.

2 participants