Skip to content

revert: close pool early in run-mode #4623#4715

Merged
sheremet-va merged 2 commits intovitest-dev:mainfrom
sheremet-va:revert/perf-close-pool-early
Dec 9, 2023
Merged

revert: close pool early in run-mode #4623#4715
sheremet-va merged 2 commits intovitest-dev:mainfrom
sheremet-va:revert/perf-close-pool-early

Conversation

@sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Dec 9, 2023 •
edited
Loading

Description

Reverting #4623 because public API can call start/stop at any time.

This PR will be merged non-squashed.

Fixes #4713

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Dec 9, 2023 •
edited
Loading

✅ Deploy Preview for fastidious-cascaron-4ded94 ready!

Name Link
🔨 Latest commit 659e14f
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/65745a5ce5c8bd000808314a
😎 Deploy Preview https://deploy-preview-4715--fastidious-cascaron-4ded94.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AriPerkkio
Copy link
Member

AriPerkkio commented Dec 9, 2023

So when JS API users are calling vitest.start() again, the pool is already closed?

@sheremet-va
Copy link
Member Author

sheremet-va commented Dec 9, 2023

So when JS API users are calling vitest.start() again, the pool is already closed?

It's in the process of closing because it's not awaited

@sheremet-va sheremet-va merged commit 7e5594d into vitest-dev:main Dec 9, 2023
@sheremet-va sheremet-va deleted the revert/perf-close-pool-early branch December 9, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AriPerkkio AriPerkkio AriPerkkio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rerunning vitest with browser mode no longer works since vitest 1.0.0

2 participants

@sheremet-va @AriPerkkio