fix: inherit concurrent/sequential in nested suites#4482
Merged
sheremet-va merged 2 commits intovitest-dev:mainfrom Nov 15, 2023
inpart-io:fix-ensure-concurrent-sequential-inherited
Merged
fix: inherit concurrent/sequential in nested suites#4482sheremet-va merged 2 commits intovitest-dev:mainfrom inpart-io:fix-ensure-concurrent-sequential-inherited
sheremet-va merged 2 commits intovitest-dev:mainfrom
inpart-io:fix-ensure-concurrent-sequential-inherited
Conversation
✅ Deploy Preview for fastidious-cascaron-4ded94 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sheremet-va
approved these changes
Nov 13, 2023
This was referenced Nov 15, 2023
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4480
Currently,
describe.sequentialhas no effect asdescribedoes not correctly inherit theconcurrentoption from the parent suite (reproduction). This PR fixes the inheritance ofconcurrent/sequentialoptions so that tests withindescribenested withindescribe.concurrentrun concurrently.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.