fix: apply serializer to Error instance for thrown snapshot#4396
Merged
sheremet-va merged 12 commits intovitest-dev:mainfrom Nov 2, 2023
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #3655
As explained in #3655 (comment), currently vitest hard-codes specific behavior to extract
Error.messageforErrorinstance when it's snapshot-ed viatoThrowErrorMatching..., which prevents error from being applied with user-provided serializer.This PR removes this special behavior, so that
Errorinstance's snapshot is a consistent regardless of whether its snapshote-ed viatoMatchInlineSnapshotortoThrowErrorMatchingInlineSnapshot.Due to the removal of
Error.messageextraction, the default snapshot format changes in a following wayPlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.