Skip to content

feat: update magic-string#4345

Merged
sheremet-va merged 4 commits intovitest-dev:mainfrom
bluwy:fix-vite-5
Oct 23, 2023
Merged

feat: update magic-string#4345
sheremet-va merged 4 commits intovitest-dev:mainfrom
bluwy:fix-vite-5

Conversation

@bluwy
Copy link
Contributor

@bluwy bluwy commented Oct 20, 2023

Description

Fixes test issue with Vite 5 and Rollup 4.


Also updated pnpm. I know I probably shouldn't update pnpm, but:

  1. The lock file changed on install without changes
  2. I needed to update magic-string
  3. I'm not sure why there's so many line changes
  4. Updated react-storybook test due to peer dep mismatch after running pnpm i

So I figured to clean it up a bit.


I also updated the netlify configuration as pnpm is already supported by default. The new config is referenced from Vite's netlify.toml. Needed for the install to work.

If you check the previous netlify logs, it was already using pnpm to install the deps.


And I updated wait.test.ts as Vite now uses Rollup's parse instead of acorn, and there's a parse error when doing the const assignment.


Overall I'm currently discussing about the vite-ecosystem-ci fail at https://discord.com/channels/804011606160703521/1164793712128311306/1164844328410169344

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Oct 20, 2023

Deploy Preview for fastidious-cascaron-4ded94 ready!

Name Link
🔨 Latest commit cf6fb7e
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/6534c370bc4d2900084ce8d6
😎 Deploy Preview https://deploy-preview-4345--fastidious-cascaron-4ded94.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bluwy
Copy link
Contributor Author

bluwy commented Oct 20, 2023

Hmm lots of reds, that must be why the lockfile is this way 😄 I'll try to check it out.

bluwy added 2 commits October 22, 2023 14:33
pnpm auto installs peer deps but the specified ranges from storybook/testing-react package were incorrect
@bluwy
Copy link
Contributor Author

bluwy commented Oct 22, 2023

I think it is fixed now. The PR description is updated to reflect the changes made. The tests and netlify build are passing, except two CI tests which I think is a fluke. I ran test:browser:webdriverio locally and it passed for me.

@sheremet-va
Copy link
Member

Thank you! Yes, these tests are failing for some time now only in CI.

@sheremet-va sheremet-va merged commit fde1843 into vitest-dev:main Oct 23, 2023
@bluwy bluwy deleted the fix-vite-5 branch October 23, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants