feat: update magic-string#4345
Merged
sheremet-va merged 4 commits intovitest-dev:mainfrom Oct 23, 2023
bluwy:fix-vite-5
Merged
Conversation
|
|
✅ Deploy Preview for fastidious-cascaron-4ded94 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Author
|
Hmm lots of reds, that must be why the lockfile is this way 😄 I'll try to check it out. |
pnpm auto installs peer deps but the specified ranges from storybook/testing-react package were incorrect
Contributor
Author
|
I think it is fixed now. The PR description is updated to reflect the changes made. The tests and netlify build are passing, except two CI tests which I think is a fluke. I ran |
Member
|
Thank you! Yes, these tests are failing for some time now only in CI. |
sheremet-va
approved these changes
Oct 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes test issue with Vite 5 and Rollup 4.
Also updated pnpm. I know I probably shouldn't update pnpm, but:
magic-stringpnpm iSo I figured to clean it up a bit.
I also updated the netlify configuration as
pnpmis already supported by default. The new config is referenced from Vite's netlify.toml. Needed for the install to work.If you check the previous netlify logs, it was already using pnpm to install the deps.
And I updated
wait.test.tsas Vite now uses Rollup'sparseinstead of acorn, and there's a parse error when doing theconstassignment.Overall I'm currently discussing about the vite-ecosystem-ci fail at https://discord.com/channels/804011606160703521/1164793712128311306/1164844328410169344
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.