feat(expect): toContain can handle classList and Node.contains#4239
Merged
sheremet-va merged 6 commits intovitest-dev:mainfrom Nov 15, 2023
Merged
feat(expect): toContain can handle classList and Node.contains#4239sheremet-va merged 6 commits intovitest-dev:mainfrom
sheremet-va merged 6 commits intovitest-dev:mainfrom
Conversation
✅ Deploy Preview for fastidious-cascaron-4ded94 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Any updates on this? |
96de979 to
eff9c91
Compare
|
This update also broke my tests in https://github.com/charkour/zundo. I'm not sure why that's the case yet. |
charkour
reviewed
Dec 8, 2023
| } | ||
| // make "actual" indexable to have compatibility with jest | ||
| if (actual != null && typeof actual !== 'string') | ||
| utils.flag(this, 'object', Array.from(actual as Iterable<unknown>)) |
There was a problem hiding this comment.
I think this Array.from is causing bugs. If actual is an object, then it will always return an empty array which is an issue.
There was a problem hiding this comment.
Ah, I found that this is expected and I should instead use toMatchObject rather than toContain.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2395
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.