Skip to content

fix(vitest): inline chai types instead of using @types/chai#4209

Merged
sheremet-va merged 3 commits intovitest-dev:mainfrom
sheremet-va:feat/inline-chai-types
Oct 2, 2023
Merged

fix(vitest): inline chai types instead of using @types/chai#4209
sheremet-va merged 3 commits intovitest-dev:mainfrom
sheremet-va:feat/inline-chai-types

Conversation

@sheremet-va
Copy link
Copy Markdown
Member

@sheremet-va sheremet-va commented Oct 2, 2023

Description

Fixes #2118

By the way, this is how Cypress fixes it 😄

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typescript types adding unwanted / buggy 'Chai.Assertion' type requirement on should function interface return

3 participants