You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm trying to implement a custom reporter which uses GitHub check runs annotations based on the github actions reporter but I notice it has access to things which aren't publicly accessible.
The task type in TestModule is accessed by every other reporter so I'm not entirely sure why it's marked as internal as it seems strange that I shouldn't access it if I wanted to implement a custom reporter.
The capturePrintError is used by the junit and actions reporters so it would be useful for me to be able to use it too.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
Ideally, include a test that fails without this PR but passes with it.
Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.
Tests
Run the tests with pnpm test:ci.
Documentation
If you introduce new functionality, document it. You can run documentation with pnpm run docs command.
Changesets
Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
samchungy
changed the title
feat(node): add capturePrintError export and update TestModule
feat(node): export capturePrintError and update TestModuleMay 3, 2026
samchungy
changed the title
feat(node): export capturePrintError and update TestModule
feat(node): export capturePrintError and update TestModule type
May 3, 2026
The task type in TestModule is accessed by every other reporter so I'm not entirely sure why it's marked as internal as it seems strange that I shouldn't access it if I wanted to implement a custom reporter.
I think RunnerTestFile being internal is an intended architecture. TestModule is newer user-facing reporter API and RunnerXxx is old (and still raw internal) representation. Builtin reporter should technically operate on newer API too, but they aren't just migrated yet.
And that also means capturePrintError(..., { task }) shouldn't be a public API as is though the request sounds reasonable. We probably need to refactor something there, so exploring that aspect would be more helpful.
The task type in TestModule is accessed by every other reporter so I'm not entirely sure why it's marked as internal as it seems strange that I shouldn't access it if I wanted to implement a custom reporter.
I think RunnerTestFile being internal is an intended architecture. TestModule is newer user-facing reporter API and RunnerXxx is old (and still raw internal) representation. Builtin reporter should technically operate on newer API too, but they aren't just migrated yet.
And that also means capturePrintError(..., { task }) shouldn't be a public API as is though the request sounds reasonable. We probably need to refactor something there, so exploring that aspect would be more helpful.
Oooo I see, would you be okay if I update the PR for just exporting capturePrintError?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I'm trying to implement a custom reporter which uses GitHub check runs annotations based on the github actions reporter but I notice it has access to things which aren't publicly accessible.
The
tasktype inTestModuleis accessed by every other reporter so I'm not entirely sure why it's marked asinternalas it seems strange that I shouldn't access it if I wanted to implement a custom reporter.The
capturePrintErroris used by the junit and actions reporters so it would be useful for me to be able to use it too.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.