refactor!: remove sequential test/suite options in favor of concurrent#10198
Merged
sheremet-va merged 10 commits intovitest-dev:mainfrom Apr 27, 2026
Merged
Conversation
Co-authored-by: Codex <noreply@openai.com>
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
hi-ogawa
commented
Apr 26, 2026
| { | ||
| "basic.test.js": { | ||
| "test 1": { | ||
| "concurrent": true, |
Collaborator
Author
There was a problem hiding this comment.
This shouldn't be concurrent: true. The bug is due to
Co-authored-by: Codex <noreply@openai.com>
abc3fb4 to
3d684fe
Compare
Collaborator
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 621d047227
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
sheremet-va
approved these changes
Apr 27, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
sequential: booleanfrom test/suite options in favor of its negationconcurrent: boolean#10180Test plan
In
test/core,test/config, we already have equivalent tests enumerating bothtest.sequentialandtest(.., { concurrent: false }), so just removingsequentialones.In
test/cli,{ concurrent: false }tests are missing so replacing existingsequentialtest with{ concurrent: false }with improved coverage.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.