fix: global sequence.concurrent: true with top-level test(..., { concurrent: false }) + depreacte sequential test API and options#10194
Merged
sheremet-va merged 13 commits intovitest-dev:mainfrom Apr 25, 2026
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
sequentialsequential test API and options
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
…urrent: false })`
sequential test API and optionssequence.concurrent: true with test(..., { concurrent: false}) + depreacte sequential test API and options
sequence.concurrent: true with test(..., { concurrent: false}) + depreacte sequential test API and optionssequence.concurrent: true with test(..., { concurrent: false }) + depreacte sequential test API and options
hi-ogawa
commented
Apr 25, 2026
hi-ogawa
commented
Apr 25, 2026
| if ( | ||
| options.concurrent | ||
| || (!options.sequential && runner.config.sequence.concurrent) | ||
| ?? (!options.sequential && runner.config.sequence.concurrent) |
Collaborator
Author
There was a problem hiding this comment.
The explicit { concurrent: false } wasn't overriding global sequence.concurrent: true.
This was only for top-level test since describe already does this
vitest/packages/runner/src/suite.ts
Lines 453 to 457 in 12a9148
sequence.concurrent: true with test(..., { concurrent: false }) + depreacte sequential test API and optionssequence.concurrent: true with top-level test(..., { concurrent: false }) + depreacte sequential test API and options
sheremet-va
previously approved these changes
Apr 25, 2026
Member
sheremet-va
left a comment
There was a problem hiding this comment.
LGTM, will you backport after the merge?
Co-authored-by: Vladimir <sleuths.slews0s@icloud.com>
Co-authored-by: Vladimir <sleuths.slews0s@icloud.com>
Collaborator
Author
|
Will cherry-pick after merged. |
sheremet-va
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
sequential: booleanfrom test/suite options in favor of its negationconcurrent: boolean#10180I added
TypedChainableFunctionso that the same jsdoc get surfaced astest.sequentialandtest("...", { sequential }). This allows showingdeprecatedon IDE such as:Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.