fix(runner): propagate chainable flags in describe.for#10187
Merged
hi-ogawa merged 3 commits intovitest-dev:mainfrom Apr 25, 2026
Merged
fix(runner): propagate chainable flags in describe.for#10187hi-ogawa merged 3 commits intovitest-dev:mainfrom
hi-ogawa merged 3 commits intovitest-dev:mainfrom
Conversation
describe.concurrent.for (and other chainable modifiers like .only, .skip) were not being propagated to the generated suites because suiteFn.for was using the outer `suite` variable directly instead of calling getChainableContext(this).withContext() like suiteFn.each does. Fixes vitest-dev#10181
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
hi-ogawa
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10181
Problem
describe.concurrent.for(and other chainable modifiers like.only,.skip) were not being propagated to the generated suites.suiteFn.eachcorrectly callsgetChainableContext(this).withContext()to capture any chained flags before iterating.suiteFn.forwas missing this — it referenced the outersuitevariable directly, so modifiers likeconcurrentwere silently dropped.Fix
Apply the same pattern used in
suiteFn.each:This ensures that
describe.concurrent.for,describe.only.for,describe.skip.for, etc. all behave consistently.Test
Added a regression test to
test/core/test/test-for-suite.test.tsthat verifiestask.suite.concurrentistruewhen usingdescribe.concurrent.for.