Skip to content

fix!: default attachmentsDir from .vitest-attachements/ to .vitest/attachments/#10186

Merged
sheremet-va merged 2 commits intovitest-dev:mainfrom
MdSadiqMd:fix/change-attachmentsDir-default
Apr 26, 2026
Merged

fix!: default attachmentsDir from .vitest-attachements/ to .vitest/attachments/#10186
sheremet-va merged 2 commits intovitest-dev:mainfrom
MdSadiqMd:fix/change-attachmentsDir-default

Conversation

@MdSadiqMd
Copy link
Copy Markdown
Contributor

Description

This PR changes the default attachmentsDir from .vitest-attachments to .vitest/attachments to follow the new convention established in #9952, where all Vitest output should be organized under the .vitest/ directory.

Changes:

  • Updated default attachmentsDir from .vitest-attachments to .vitest/attachments
  • Updated .gitignore to ignore .vitest (covers all subdirectories including /attachments)
  • Updated documentation examples to upload .vitest/** in GitHub Actions workflows
  • Updated all test snapshots to reflect the new path structure

Resolves #10183

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.
  • Updated test snapshots in test/cli/test/annotations.test.ts and test/cli/test/artifacts.test.ts
  • All 22 tests passing (annotations + artifacts)

Documentation

  • Updated docs/config/attachmentsdir.md with new default value
  • Updated docs/guide/improving-performance.md with simplified GitHub Actions examples
  • Updated docs/guide/browser/visual-regression-testing.md with new path examples
  • Regenerated docs/guide/cli-generated.md

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 24, 2026

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 12dac55
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/69ecc933a5391600082400ca
😎 Deploy Preview https://deploy-preview-10186--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@AriPerkkio AriPerkkio changed the title fix: Default attachmentsDir from .vitest-attachements/ to .vitest/attachments/ fix!: default attachmentsDir from .vitest-attachements/ to .vitest/attachments/ Apr 25, 2026
@AriPerkkio AriPerkkio added this to the 5.0.0 milestone Apr 25, 2026
@sheremet-va sheremet-va merged commit 1ba7338 into vitest-dev:main Apr 26, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default attachmentsDir from .vitest-attachements/ to .vitest/attachments/

3 participants