Skip to content

fix: fix defineHelper for webkit async stack trace + update playwright 1.59.0#10036

Merged
sheremet-va merged 7 commits intovitest-dev:mainfrom
hi-ogawa:chore-deps-update-playwright
Apr 1, 2026
Merged

fix: fix defineHelper for webkit async stack trace + update playwright 1.59.0#10036
sheremet-va merged 7 commits intovitest-dev:mainfrom
hi-ogawa:chore-deps-update-playwright

Conversation

@hi-ogawa
Copy link
Copy Markdown
Collaborator

@hi-ogawa hi-ogawa commented Apr 1, 2026

Description

Webkit now has better async stack trace support now, so bumping it manually with minor fix.

Here is how vi.defineHelper looks:

$ BROWSER=webkit BROWSER_WS_ENDPOINT=true pnpm -C test/browser/ test-fixtures --
root fixtures/assertion-helper 

> @vitest/test-browser@ test-fixtures /home/hiroshi/code/others/vitest-wt1/test/browser
> vitest --root fixtures/assertion-helper


 DEV  v4.1.2 /home/hiroshi/code/others/vitest-wt1/test/browser/fixtures/assertion-helper

 ❯  webkit  basic.test.ts (4 tests | 4 failed) 29ms
   × sync 5ms
   × async 21ms
   × soft 0ms
   × soft async 2ms

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Failed Tests 4 ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯

 FAIL   webkit  basic.test.ts:21:6 > sync
AssertionError: expected 'sync' to deeply equal 'x'

Expected: "x"
Received: "sync"

 ❯ basic.test.ts:22:10
     20|
     21| test('sync', () => {
     22|   myEqual('sync', 'x')
       |          ^
     23| })
     24|

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/4]⎯

 FAIL   webkit  basic.test.ts:25:6 > async
AssertionError: expected 'async' to deeply equal 'x'

Expected: "x"
Received: "async"

 ❯ basic.test.ts:26:21
     24|
     25| test('async', async () => {
     26|   await myEqualAsync('async', 'x')
       |                     ^
     27| })
     28|

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[2/4]⎯

 FAIL   webkit  basic.test.ts:29:6 > soft
AssertionError: expected 'soft' to deeply equal 'x'

Expected: "x"
Received: "soft"

 ❯ basic.test.ts:30:14
     28|
     29| test('soft', () => {
     30|   myEqualSoft('soft', 'x')
       |              ^
     31| })
     32|

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[3/4]⎯

 FAIL   webkit  basic.test.ts:33:6 > soft async
AssertionError: expected 'soft async' to deeply equal 'x'

Expected: "x"
Received: "soft async"

 ❯ basic.test.ts:34:25
     32|
     33| test('soft async', async () => {
     34|   await myEqualSoftAsync('soft async', 'x')
       |                         ^
     35| })
     36|

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[4/4]⎯


 Test Files  1 failed (1)
      Tests  4 failed (4)
   Start at  11:55:12
   Duration  1.23s (transform 0ms, setup 0ms, import 11ms, tests 29ms, environment 0ms)

 FAIL  Tests failed. Watching for file changes...
       press h to show help, press q to quit
 ELIFECYCLE  Command failed with exit code 1.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 1, 2026

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 82986a7
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/69cc8b032b90e700088cf137
😎 Deploy Preview https://deploy-preview-10036--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hi-ogawa hi-ogawa changed the title chore(deps): update playwright fix(browser): fix defineHelper for webkit async stack trace + update playwright 1.59.0 Apr 1, 2026
Comment on lines -129 to -134

::: warning

Currently a source view of a trace can be only displayed properly when viewing it on the machine generated a trace with `playwright show-trace` CLI. This is expected to be fixed soon (see https://github.com/microsoft/playwright/pull/39307).

:::
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hi-ogawa hi-ogawa changed the title fix(browser): fix defineHelper for webkit async stack trace + update playwright 1.59.0 fix: fix defineHelper for webkit async stack trace + update playwright 1.59.0 Apr 1, 2026
@hi-ogawa hi-ogawa marked this pull request as ready for review April 1, 2026 04:22
@sheremet-va sheremet-va merged commit 5a5fa49 into vitest-dev:main Apr 1, 2026
16 checks passed
@hi-ogawa hi-ogawa deleted the chore-deps-update-playwright branch April 1, 2026 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants