fix: fix defineHelper for webkit async stack trace + update playwright 1.59.0#10036
Merged
sheremet-va merged 7 commits intovitest-dev:mainfrom Apr 1, 2026
Merged
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
defineHelper for webkit async stack trace + update playwright 1.59.0
hi-ogawa
commented
Apr 1, 2026
Comment on lines
-129
to
-134
|
|
||
| ::: warning | ||
|
|
||
| Currently a source view of a trace can be only displayed properly when viewing it on the machine generated a trace with `playwright show-trace` CLI. This is expected to be fixed soon (see https://github.com/microsoft/playwright/pull/39307). | ||
|
|
||
| ::: |
Collaborator
Author
There was a problem hiding this comment.
Also this one is resolved. I verified this on https://trace.playwright.dev/
defineHelper for webkit async stack trace + update playwright 1.59.0defineHelper for webkit async stack trace + update playwright 1.59.0
sheremet-va
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Webkit now has better async stack trace support now, so bumping it manually with minor fix.
Here is how
vi.defineHelperlooks:Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.