fix(vm): fix external module resolve error with deps optimizer query#10024
Merged
sheremet-va merged 7 commits intovitest-dev:mainfrom Mar 30, 2026
Merged
Conversation
…alModulesExecutor Vite appends `?v=<browserHash>` to optimized-dep URLs for cache busting. When vmThreads externalizes such a dep, the path including `?v=...` was passed directly to `fs.existsSync`, which has no concept of URL query params, causing a "Cannot find module" error. Fix by splitting the identifier into path and query upfront via `cleanUrl`, then reconstructing the file URL with the query preserved for module cache identity while using the clean path for filesystem operations. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
…alModulesExecutor Vite appends `?v=<browserHash>` to optimized-dep URLs for cache busting. When vmThreads externalizes such a dep, the path including `?v=...` was passed directly to `fs.existsSync`, which has no concept of URL query params, causing a "Cannot find module" error. Fix by splitting the identifier into path and query upfront via `splitFileAndPostfix`, then reconstructing the file URL with the query preserved for module cache identity while using the clean path for filesystem operations. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
hi-ogawa
commented
Mar 30, 2026
| } | ||
|
|
||
| const extension = extname(identifier) | ||
| const { file, postfix } = splitFileAndPostfix(identifier) |
Collaborator
Author
There was a problem hiding this comment.
Added splitFileAndPostfix here, so later pathUrl won't include ?v=..., which was the cause of existsSync not finding the file and causing module not found.
sheremet-va
approved these changes
Mar 30, 2026
|
Any ideas when this may release as a patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.