Skip to content

fix(expect): don't leak "runner" types#10004

Merged
sheremet-va merged 1 commit intovitest-dev:mainfrom
sheremet-va:fix/dont-leak-runner-types
Mar 28, 2026
Merged

fix(expect): don't leak "runner" types#10004
sheremet-va merged 1 commit intovitest-dev:mainfrom
sheremet-va:fix/dont-leak-runner-types

Conversation

@sheremet-va
Copy link
Copy Markdown
Member

Description

Resolves #issue-number

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 28, 2026

Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit afe2985
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/69c787ad22e5e80008eb547a
😎 Deploy Preview https://deploy-preview-10004--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sheremet-va sheremet-va merged commit ec20455 into vitest-dev:main Mar 28, 2026
16 checks passed
@hi-ogawa
Copy link
Copy Markdown
Collaborator

I'm getting red squiggle inside packages/expect.

Object literal may only specify known properties, and 'task' does not exist in type 'MatcherState'.ts(2353)
(property) task: Test<object> | undefined
image

Probably due to the difference of pnpm typecheck from root and packages/expect/tsconfig.json. Never understood how these typing is supposed to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants