-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Description
Describe the bug
File filter display seems inconsistent with what's re-run when filtering and also with the count in the label.
Here is a reproduction https://stackblitz.com/edit/vitest-dev-vitest-m3inyx
(no change from the original template https://stackblitz.com/fork/github/vitest-dev/vitest/tree/main/examples/react-testing-lib)
- Search by "count"
- File list shows only
useCounter.test.tsbut with a label "Pass (2)" - Press "Rerun filtered" and see
useCounter.test.tsandApp.test.tsare executed in the terminal
Note that App.test.ts includes test case named should increment count on click and I assumed matching the test suite/case names is an intended behavior since that's the feature introduced in #1035.
I think the issue is due to TaskTree is hiding TaskItem by unnecessary condition when used from TasksList while TasksList already applies filter to hide TaskTree:
vitest/packages/ui/client/components/TaskTree.vue
Lines 19 to 20 in 9c552b6
| <TaskItem | |
| v-if="!search || caseInsensitiveMatch(task.name, search)" |
Reproduction
https://stackblitz.com/edit/vitest-dev-vitest-m3inyx
System Info
(stackblitz)Used Package Manager
npm
Validations
- Follow our Code of Conduct
- Read the Contributing Guidelines.
- Read the docs.
- Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
- Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
- The provided reproduction is a minimal reproducible example of the bug.
