Skip to content

Unnecessary (?) check for if vite is installed #4656

@wojtekmaj

Description

@wojtekmaj

Describe the bug

I'm currently facing a blocker (#4655) from upgrading vitest to 1.0. However, I'm struggling to understand why the check for whether vite is installed is even there? vite is declared directly in vitest dependency so there's no physical way vite would ever be missing, and the whole check is just slowing things down. Am I wrong?

Reproduction

  • Install vitest using Yarn PnP
  • Run vitest

System Info

System:
    OS: macOS 14.1.1
    CPU: (8) arm64 Apple M2
    Memory: 32.31 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.9.0 - /private/var/folders/3y/swkjq1x101b76mzjgt4pm2d80000gp/T/xfs-2ac5acc4/node
    Yarn: 4.0.2 - /private/var/folders/3y/swkjq1x101b76mzjgt4pm2d80000gp/T/xfs-2ac5acc4/yarn
    npm: 10.1.0 - /usr/local/bin/npm
    bun: 1.0.12 - ~/.bun/bin/bun
  Browsers:
    Chrome: 119.0.6045.199
    Edge: 119.0.2151.97
    Safari: 17.1

Used Package Manager

yarn

Validations

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions