Skip to content

Commit b094053

Browse files
authored
fix(coverage): remove unnecessary istanbul-lib-source-maps usage (#9344)
1 parent 9e2636b commit b094053

File tree

3 files changed

+4
-73
lines changed

3 files changed

+4
-73
lines changed

packages/coverage-v8/package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@
5959
"ast-v8-to-istanbul": "^0.3.8",
6060
"istanbul-lib-coverage": "catalog:",
6161
"istanbul-lib-report": "catalog:",
62-
"istanbul-lib-source-maps": "catalog:",
6362
"istanbul-reports": "catalog:",
6463
"magicast": "catalog:",
6564
"obug": "catalog:",
@@ -69,7 +68,6 @@
6968
"devDependencies": {
7069
"@types/istanbul-lib-coverage": "catalog:",
7170
"@types/istanbul-lib-report": "catalog:",
72-
"@types/istanbul-lib-source-maps": "catalog:",
7371
"@types/istanbul-reports": "catalog:",
7472
"@vitest/browser": "workspace:*",
7573
"pathe": "catalog:",

packages/coverage-v8/src/provider.ts

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import { mergeProcessCovs } from '@bcoe/v8-coverage'
99
import astV8ToIstanbul from 'ast-v8-to-istanbul'
1010
import libCoverage from 'istanbul-lib-coverage'
1111
import libReport from 'istanbul-lib-report'
12-
import libSourceMaps from 'istanbul-lib-source-maps'
1312
import reports from 'istanbul-reports'
1413
import { parseModule } from 'magicast'
1514
import { createDebug } from 'obug'
@@ -61,16 +60,15 @@ export class V8CoverageProvider extends BaseCoverageProvider<ResolvedCoverageOpt
6160
})
6261
},
6362
onFinished: async (project, environment) => {
63+
// Source maps can change based on projectName and transform mode.
64+
// Coverage transform re-uses source maps so we need to separate transforms from each other.
6465
const converted = await this.convertCoverage(
6566
merged,
6667
project,
6768
environment,
6869
)
6970

70-
// Source maps can change based on projectName and transform mode.
71-
// Coverage transform re-uses source maps so we need to separate transforms from each other.
72-
const transformedCoverage = await transformCoverage(converted)
73-
coverageMap.merge(transformedCoverage)
71+
coverageMap.merge(converted)
7472

7573
merged = { result: [] }
7674
},
@@ -83,7 +81,7 @@ export class V8CoverageProvider extends BaseCoverageProvider<ResolvedCoverageOpt
8381
const coveredFiles = coverageMap.files()
8482
const untestedCoverage = await this.getCoverageMapForUncoveredFiles(coveredFiles)
8583

86-
coverageMap.merge(await transformCoverage(untestedCoverage))
84+
coverageMap.merge(untestedCoverage)
8785
}
8886

8987
coverageMap.filter((filename) => {
@@ -458,11 +456,6 @@ export class V8CoverageProvider extends BaseCoverageProvider<ResolvedCoverageOpt
458456
}
459457
}
460458

461-
async function transformCoverage(coverageMap: CoverageMap) {
462-
const sourceMapStore = libSourceMaps.createSourceMapStore()
463-
return await sourceMapStore.transformCoverage(coverageMap)
464-
}
465-
466459
/**
467460
* Find the function with highest `endOffset` to determine the length of the file
468461
*/

pnpm-lock.yaml

Lines changed: 0 additions & 60 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)