fix: support empty template in parseAriaTemplate#17
Merged
hi-ogawa merged 4 commits intovitest-dev:masterfrom Apr 27, 2026
Merged
fix: support empty template in parseAriaTemplate#17hi-ogawa merged 4 commits intovitest-dev:masterfrom
hi-ogawa merged 4 commits intovitest-dev:masterfrom
Conversation
3 tasks
commit: |
hi-ogawa
approved these changes
Apr 27, 2026
Collaborator
hi-ogawa
left a comment
There was a problem hiding this comment.
Thanks. Adjusted some test cases with more coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16
Problem
parseAriaTemplate('')throws "Aria snapshot must be a YAML sequence" becauseyaml.parseDocument('')returnscontents: null, which is not aYAMLSeq.Fix
Add an early return for
nullcontents — return an empty fragment node{ kind: 'role', role: 'fragment' }with no errors. This also simplifies theexisting error path since
yamlDoc.contentsis guaranteed non-null after thenew guard, removing the ternary fallback for the range.
Context
This unblocks the vitest-side fix for vitest-dev/vitest#10158
(vitest-dev/vitest#10188), which correctly distinguishes empty string from
undefined in domain snapshots but needs ivya to handle empty templates.
Test
Updated the existing
empty inputtest case intest/aria.test.tsto expectan empty fragment instead of an error.